fix(verify): honor double-confirm email change when mailer_autoconfirm is enabled (fixes #2600) - #2711
Open
deepshekhardas wants to merge 1 commit into
Conversation
…m is enabled (fixes supabase#2600)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(verify): honor double-confirm email change when mailer_autoconfirm is enabled (fixes #2600)
GOTRUE_MAILER_SECURE_EMAIL_CHANGE_ENABLED=truewas silently bypassedwhenever
GOTRUE_MAILER_AUTOCONFIRM=true: the guard inemailChangeVerifyANDed
!config.Mailer.Autoconfirmwith the double-confirm checks, so thetwo-token flow was skipped and the email change committed after a single
confirmation click. Autoconfirm only governs signup confirmation and is
orthogonal to email-change confirmation.
Remove
!config.Mailer.Autoconfirmfrom the guard so double-confirmholds regardless of the signup autoconfirm setting, and add
TestVerifySecureEmailChangeAutoconfirmEnabledcovering theautoconfirm=true + secure-email-change=true combination (first token
must not commit, second token commits).