fix(formatter): preserve comments - #768
Merged
Merged
Conversation
Collaborator
|
Thanks for the contribution! I am touching grass at the moment, but will come back to this next week. 🫶 |
psteinroe
reviewed
Jul 19, 2026
psteinroe
left a comment
psteinroe
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the contribution! i would love to actually support comments at some point but this should at least unlock usage of the formatter for most people.
one thing: could you adapt the note in the formatter docs to explain the new behaviour?
thanks!
Contributor
Author
|
Did small update on formatting.md. If you think more info is needed, let me know. |
psteinroe
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix #767
What is the current behavior?
Comments are not preserved on format
What is the new behavior?
Comments are reinserted into formated statements
Additional context
Code is AI generated, but reviewed by me. Tests also are created and looks good.