Skip to content

Refresh rank-history catalog and credential permission fixture #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunlover7 merged 1 commit into from
Oct 7, 2026
Merged

Refresh rank-history catalog and credential permission fixture #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cli/catalog.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion test/citation-login.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,12 @@ for (const unsafe of ['directory-mode', 'directory-symlink', 'file-mode', 'file-
if (unsafe === 'directory-symlink') {
const target = join(f.dir, 'actual'); await fs.rename(f.sessionDir, target); await fs.symlink(target, f.sessionDir);
}
if (unsafe === 'file-mode') await fs.writeFile(f.sessionPath, 'previous session', { mode: 0o644 });
if (unsafe === 'file-mode') {
await fs.writeFile(f.sessionPath, 'previous session', { mode: 0o644 });
// Creation mode is masked by the caller's umask; make the unsafe fixture real.
await fs.chmod(f.sessionPath, 0o644);
assert.equal((await fs.lstat(f.sessionPath)).mode & 0o7777, 0o644);
}
if (unsafe === 'file-directory') await fs.mkdir(f.sessionPath);
await assert.rejects(login(f), { code: 'PRIVATE_STORAGE_REQUIRED' });
if (unsafe === 'file-mode') assert.equal(await readFile(f.sessionPath, 'utf8'), 'previous session');
Expand Down
Loading