Add exclude_prefixes parameter to get_macs/get_ips for virtual interface filtering - #1
Open
jshessen wants to merge 1 commit into
Open
Conversation
This was referenced Mar 26, 2026
Author
Author
|
Hi @cavonlee, quick alignment note so you can choose the preferred direction. I compared this PR branch against upstream fix/filter-virtual-interfaces at code level in sf_rpi_status/status.py. Current branch intent:
Upstream fix/filter branch intent:
So they overlap in area, but differ in control model:
Downstream dependencies currently rely on configurable behavior:
Happy to take either path you prefer:
If you pick one, I will update all linked PRs to match your preferred direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Transient Docker and bridge interfaces create unstable interface names that pollute downstream persistent metrics.
Root Cause
get_macs()andget_ips()currently enumerate all kernel-visible interfaces with no caller-controlled filtering.Change
exclude_prefixesto_get_ips()exclude_prefixestoget_ips()exclude_prefixestoget_macs()exclude_prefixesisNoneVerification
python3 -m py_compile sf_rpi_status/status.pyveth,br-, anddockerprefixesDependency Status
pm_autodependency PR: Add virtual_interface_prefixes to default configuration pm_auto#15 (open, basev2)pm_dashboarddependency PR: Reduce history wildcard payloads and add runtime virtual-interface prefix filtering pm_dashboard#10 (open, basev2)Upstream Overlap Status
upstream/fix/filter-virtual-interfacesexclude_prefixes) instead of hardcoding interface-name prefixes.Impact
Enables downstream packages to prevent unbounded metric key growth caused by transient virtual interfaces.