Conversation
Previously ClickhouseTransport::poll_next did not tries to process packets if the server closed the connection, however there can be some packet (likely Exception), that we need to pass to user. Also this will avoid panic in case of missing Hello packet, i.e. in case of credentials mismatch.
* fix-panic-on-hello: ci: set CLICKHOUSE_SKIP_USER_SETUP to avoid restricting default user Fix test_size_of expectation (the size should be 64 with alignment) Properly handle terminated connection by the server Ensure that Hello packet correctly received
This reverts commit f7395a3.
This was referenced Apr 19, 2025
|
It would be very good to see this PR merged but I don't see any reaction from the author. I don;t see any commit/activity on github from him in the last year, so I doubt we will get some news here. Maybe we should fork this project @azat ? |
Contributor
Author
|
Let's the maintainer more time, it is really hard to support open source projects after some time when you have full time job... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: blocked by #226 hence draft for now
mTLS (Mutual TLS, or mTLS for short, is a method for mutual authentication) allows you to authenticate on the server with client certificate.
Now
clickhouse-rssupports it, for this you need to pass the following arguments for connection url:ca_certificateclient_certificateclient_private_keySome other things:
ca_certificateparameter in URLDebugtrait