fix: normalize high-level media comments - #427
Merged
Merged
Conversation
Return Comment models consistently from the public GraphQL path while preserving low-level raw helpers. Expose child_comment_count and sanitize malformed GraphQL normalization failures before falling back to the private API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client.media_comments()consistently returnlist[Comment]when the public GraphQL path succeeds, including after public-session injection and retry.Comment.child_comment_countwhile preserving the difference between a missing value and a real zero.Fixes #424
Test coverage
Commentmodels as expected, andchild_comment_countmatched the raw private response.Pre-landing review
No P0, P1, or P2 findings remain after independent coverage and adversarial reviews. Ruff, mypy baseline, Bandit, strict documentation build, dependency audit, formatting, and diff checks pass.
Design review
No frontend files changed.
Plan completion
No committed plan file exists. The diff is limited to the four files required for #424, and all requested behavior is covered.
Test plan
Commentmodels.