Add on-device per-message translation#88
Draft
rexbron wants to merge 5 commits into
Draft
Conversation
User-initiated translation for received messages using Apple's Translation framework. The detected source language is checked against the user's current locale and skipped when already readable; otherwise the message is queued and translated on-device. The system download prompt is reached via SwiftUI's `.translationTask` (the only public entry point that triggers it), with a pool of three slots so up to three translations run in parallel. Translated messages get a translate-glyph badge, swap the bubble body to the translated text, and reveal the original via tooltip. The context menu and long-press popover both expose Translate / Show Original. Edit, copy, reply, and quote continue to operate on the original body — translation is presentation-only and not persisted. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
# Conflicts: # Relay/Views/Message/MessageView.swift # Relay/Views/Timeline/MessageGrouping.swift # Relay/Views/Timeline/TimelineRowView.swift # Relay/Views/Timeline/TimelineTableViewRepresentable.swift # Relay/Views/Timeline/TimelineView.swift
# Conflicts: # Relay/Views/Message/MessageView.swift # Relay/Views/Pickers/ReactionPickerCapsule.swift # Relay/Views/Timeline/TimelineRowView.swift
Upstream's reaction-UX redesign removed the inline long-press emoji popover that hosted MessageView's translate action, leaving `MessageView.canTranslate` and `onTranslationAction` wired but unused. Remove both properties and stop passing them from TimelineRowView; the translate affordance remains in the context menu, and translated text / the translate badge still render via `MessageView.translation`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`.translationTask(configuration)` only re-runs when the Configuration value changes, so re-translating a message after reverting to the original (same source→target pair) built an equal Configuration that SwiftUI never re-fired — leaving the row stuck on the loading spinner. The slot now keeps its configuration and calls `invalidate()` (Apple's re-run mechanism) when the next request reuses the same language pair, reassigning only when the pair differs. Also rename the context-menu entry from "Translate" to "Translate Message". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-device per-message translation
User-initiated, presentation-only translation of received messages using
Apple's Translation framework — entirely on-device, nothing persisted or
sent off the machine.
Behaviour
source language is checked against your locale and skipped when the message
is already readable.
translate-glyph badge, and reveals the original on hover.
Implementation
RelayKit/Translation/MessageTranslator.swiftwraps language detection +translation; the view model owns the per-message state
(
idle/loading/translated/failed) and a pending queue..translationTask(the only public trigger), driven by a pool of 3 parallel slots.
MessageRowso the table reloads onlythe affected row when a translation lands.
Configuration.invalidate()when reusingthe same language pair, since
.translationTaskwon't re-run for anunchanged configuration.
Test plan
shows the original.
🤖 Generated with Claude Code