Skip to content

fix incorrect auto-filling of default E, tau, k parameter lengths in SCPCM - #1009

Merged
SpatLyu merged 4 commits into
stscl:mainfrom
SpatLyu:dev
Jul 19, 2026
Merged

fix incorrect auto-filling of default E, tau, k parameter lengths in SCPCM#1009
SpatLyu merged 4 commits into
stscl:mainfrom
SpatLyu:dev

Conversation

@SpatLyu

@SpatLyu SpatLyu commented Jul 18, 2026

Copy link
Copy Markdown
Member

This PR fixes a critical bug in the auto-filling (recycling) logic for the embedding dimension (E), spatial lag step (tau), and number of neighbors (k) parameters in the Spatially Convergent Partial Cross Mapping (SCPCM) method.

The new logic intelligently handles parameter expansion based on the input length:

  • Length 1: The single value is applied to all variables (cause, effect, and all controls).
  • Length 2: The first value is assigned to cause and effect; the second value is recycled for all controls. (Highly useful for setting different embedding dimensions for target vs. control variables).
  • Length ≥ 3: The first two values are assigned to cause and effect; the remaining values are recycled specifically for the controls.

@SpatLyu SpatLyu self-assigned this Jul 18, 2026
@SpatLyu
SpatLyu merged commit 26ec229 into stscl:main Jul 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant