Repository navigation
build(deps): update signature primitives to 0.18 - #342
Conversation
Move structured-asn1, structured-pkix, structured-cms, structured-xades and structured-ltv to 0.18.0, which carries the DSTU 4145 structural profiles in structured-pkix. No call site changes are needed. Closes #341
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update dependency requirements Cargo.toml, crates/xml-sec-xades/Cargo.toml, tools/xmlsec1/Cargo.toml, vendor/sxd-document-no-unsafe/Cargo.toml |
These manifests now specify version 0.18.0 for the listed structured dependencies. Existing feature and optional settings remain unchanged. |
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Other
Possibly related PRs
- structured-world/xml-sec#289: Updates the same coordinated structured dependency graph in the same manifests.
- structured-world/xml-sec#283: Updates the shared primitive dependencies and adapts consumers to a published PKIX contract.
- structured-world/xml-sec#323: Updates the same dependency graph and uses the published CMS reader.
Merge Risk: 
3bd9d
-
No merge-blocking dependency or resolution issue was identified.
Pre-merge checks: 
-
Check name Status Explanation Resolution Linked Issues check The changed manifests update all five primitive dependencies from 0.17.1 to 0.18.0. The PR reports that no call-site changes were needed and that the XAdES, PKIX, CMS, and CLI key-handling tests pass.… Provide reviewable evidence from the applicable lockfile that all five primitives resolve to one 0.18 version. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the dependency updates from version 0.17.1 to 0.18.0. Out of Scope Changes check The reported changes update primitive dependency requirements in the root, XAdES, CLI, and vendored DOM manifests. The reported benchmark lockfile update supports the same dependency upgrade. These ch… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Full details: Out of Scope Changes check
-
Explanation
The reported changes update primitive dependency requirements in the root, XAdES, CLI, and vendored DOM manifests. The reported benchmark lockfile update supports the same dependency upgrade. These changes are connected to issue
#341. No unrelated change is identified.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)
-
Full details: Linked Issues check
-
Explanation
The changed manifests update all five primitive dependencies from 0.17.1 to 0.18.0. The PR reports that no call-site changes were needed and that the XAdES, PKIX, CMS, and CLI key-handling tests pass. The evidence does not establish that the reviewed lockfile resolves all primitives to one 0.18 version. The root lockfile is not present in the supplied change summary, and the benchmark lockfile is intentionally excluded from review.
Resolution
Provide reviewable evidence from the applicable lockfile that all five primitives resolve to one 0.18 version.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Summary
structured-pkix.Changes
structured-asn1,structured-pkix,structured-cms,structured-xadesandstructured-ltvmove to 0.18.0 in the root, XAdES, CLI and vendored DOM manifests.benchmarks/competitors/Cargo.lockfollows the same versions.Testing
Tests with the xmlsec1 oracle and PKCS#11 pass on macOS for the library with all features, the CLI, the XAdES crate and the corpus. CI runs the full gates on all platforms.
Closes #341
Summary by CodeRabbit