Added support for the android native platforms - #293
Merged
Merged
Conversation
nadavgu
force-pushed
the
nadavgu/android-native
branch
2 times, most recently
from
September 26, 2025 15:47
b66c437 to
48e77f5
Compare
nadavgu
force-pushed
the
nadavgu/android-native
branch
from
September 26, 2025 15:48
48e77f5 to
de19cfc
Compare
garyp
approved these changes
Oct 9, 2025
Collaborator
|
Thanks @nadavgu!
I'll merge this PR as is, but it would be nice to have support for running the conformance tests on Android devices. We've had a long-standing issue open relating to this: #128. So even if you have an in-progress branch with your changes, it'd be helpful to have as a starting point. |
Contributor
Author
|
Opened a PR for it #294 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for the following platforms:
androidNativeArm64androidNativeArm32Taken inspiration from the PR that added support for mingwX64
Ran the conformance tests for both platforms locally on an android device.
But didn't upload the modifications required to do so (modifications in the test script to also run on a connected android device using adb when a flag is passed & changes to conformance-native to support 32bit).
Tell me if I should :)