OBS merge 32.1.1#734
Open
aleksandr-voitenko wants to merge 435 commits into
Open
Conversation
Feature was removed in Ccache 4.12, which is provided by Homebrew by default since 2025-10-19.
obsproject/obs-browser@2bf7e77 - Restore source visibility code obsproject/obs-browser@4056a31 - Update version to 2.26.2
This removes the need to provide an undocumented launch argument to enable custom RTMP service configurations to use multitrack encoding and also provide a custom configuration.
When an 'Audio Capture Source' device is also used for monitoring, the deduplication logic is applied: all monitored sources are silenced. But this should not silence the 'Audio Capture Source' if for some reason, it is being monitored (the user will get echoes, but hey, it's their choice). So we exclude the 'Audio Capture Source' from the silenced sources. Signed-off-by: pkv <pkv@obsproject.com>
The commit adds a log line to inform the user that deduplication is being applied. The info is displayed whenever deduplication first occurs. Signed-off-by: pkv <pkv@obsproject.com>
Fix an issue where the stack around the variable snapEnabled was corrupted. SPI_GETSNAPTODEFBUTTON should use BOOL, not bool. Reference: * https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-systemparametersinfow
By explicitly setting the OAuth dialog as the parent of the CEF widget, it will automatically by cleaned up as soon as the dialog is closed itself. This also detaches the destruction of the widget from the browser cleanup code.
Per the Apple documentation, when 0 is returned from IOSurfaceGetPixelFormat, the IOSurface is invalid. Prior to [1] however, any invalid surfaces were (likely accidentally) treated as 32BGRA. And as it turns out, any IOSurface received from Syphon does not have the pixel format set, thus returning 0. Because the pixel format happens to always be 32BGRA, this was never caught. [1] then slightly refactored the code, fixing the bug not realizing it ever existed. This lead to Syphon no longer working. Treating 0 as 32BGRA appears to be the only way to fix this situation for now and restore prior behavior. Ideally in the future Syphon provides valid IOSurfaces. An upstream fix to Syphon-Framework is already submitted, however even if merged, servers would need to update to that fixed version before things work again. Therefore, this workaround is needed on the OBS side. However, the plan for now is for the Metal renderer to not get this relaxation. It never had it (so Syphon never worked there, making this not a regression) and it's marked as experimental. Hopefully, by the time it's stable and/or default, Syphon will be fixed and servers have been updated. [1]: 53ad05d
"DrawOpaque" only exists in the default_rect effect, in the normal cases it's just "Draw" in the opaque default shader.
Monitoring deduplication must be applied only to tracks for which the monitored source and the 'Audio Output Capture' source are both enabled. This adds such checks. Signed-off-by: pkv <pkv@obsproject.com>
Pulse audio may append .monitor to device id; this commit adds this case to the deduplication trigger. Signed-off-by: pkv <pkv@obsproject.com>
When the 'Audio Output Capture' source (usually Desktop Audio) has its fader at minimum, we should disable the deduplication logic. This is done by checking against the obs_source volume member. Signed-off-by: pkv <pkv@obsproject.com>
Request a code modification due to the change of AfreecaTV name. Effective October 15 2024, AfreecaTV has been rebranded to SOOP Korea.
Additionally, update info links.
This allows retrieval of the default audio output capture device. Signed-off-by: pkv <pkv@obsproject.com>
This adds comparison to default devices to the monitoring deduplication. When a user picks a default device, the device_id setting is 'default', which prevents any comparison. The comparison is done by leveraging the libobs/audio-monitoring devices_match function. For macOS, some special care is taken because the devices list differ for 'Desktop Audio' and 'monitoring' since coreaudio sdk has no pure audio capture; so 'default' in the two lists do not match in general. One then retrieves the device_id for the default desktop audio for macOS through get_desktop_default_id function. Signed-off-by: pkv <pkv@obsproject.com>
This adds the devices_match function to null monitor to fix linking issues on linux when pulse audio is disabled. Fixes obsproject#12810 Signed-off-by: pkv <pkv@obsproject.com>
CI: Pin GitHub actions
This was partially addressed in obsproject#13118 but this check was missed
Pinned sources were appearing before Global, which was not intended
When an Audio Output Capture source (AOC) like 'Desktop Audio' has monitoring_type == OBS_MONITORING_TYPE_MONITOR_ONLY, deduplication should not be triggered. this is an edge case which may not cover a reasonable use case, but for the sake of completeness, we deal with it. Signed-off-by: pkv <pkv@obsproject.com>
Fix a build issue with Clang 21.
# Conflicts: # libobs-d3d11/d3d11-shader.cpp
# Conflicts: # libobs/obs.c
5093c4b to
9b2e608
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: