fix(a11y): Add email label for accessibility - #437
Open
code-qtzl wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for storybook-addon-catalog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for storybook-frontpage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe newsletter form now renders a screen-reader-only label for the email input, associated with ChangesNewsletter form accessibility
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sidnioulz
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #435
Description
Adds an accessible label to the email
<input>in the global footer newsletter form.The field previously had only a
placeholder, which is not a valid label substitute, screen readers announce it as an unlabeled "edit text" field.Fix
Add a visually-hidden label associated to the input:
+ <label htmlFor="email" className="ui-sr-only">Email address</label> <input id="email" type="email" name="email" placeholder="you@domain.com" ... />Summary by CodeRabbit