Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares the migraph v1.7.0 release by bumping minimum dependency versions, improving diffusion simulation compatibility with stocnet inputs, and updating/expanding dataset documentation (including new combined multilevel/longitudinal mpn_* datasets and deprecation notices).
Changes:
- Bumped package version to 1.7.0 and raised minimum
{manynet},{autograph}, and{netrics}versions. - Fixed
play_diffusions()forstocnetinputs by coercing toigraphprior to calling{manynet}diffusion logic. - Updated dataset docs/NEWS/CONTRIBUTING and improved the release workflow to populate GitHub Release notes from
NEWS.md.
Reviewed changes
Copilot reviewed 16 out of 39 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
R/model_diffusion.R |
Adds stocnet coercion for play_diffusions() compatibility. |
R/data_mpn.R |
Adds/updates roxygen docs for merged/converted mpn_* datasets and deprecations. |
NEWS.md |
Adds release notes section for 1.7.0. |
DESCRIPTION |
Bumps version to 1.7.0 and raises minimum dependency versions. |
cran-comments.md |
Updates CRAN submission notes (incl. reverse-dep context and formatting). |
.github/workflows/pushrelease.yml |
Extracts release notes from NEWS.md and uses them as the GitHub Release body. |
.github/CONTRIBUTING.md |
Expands contributing guidance, including dataset conventions and workflow expectations. |
man/make_play.Rd |
Documents stocnet as an accepted input type. |
man/mpn_senate.Rd |
New dataset documentation for merged mpn_senate. |
man/mpn_senate112.Rd |
Updates docs for superseded mpn_senate_* community datasets. |
man/mpn_evs_combined.Rd |
New docs for combined EVS longitudinal datasets. |
man/mpn_evs.Rd |
Updates docs for superseded EVS year-by-country datasets. |
man/mpn_cow_combined.Rd |
New docs for merged mpn_cow. |
man/mpn_cow_separate.Rd |
Renames/separates docs for mpn_cow_trade/mpn_cow_igo alongside merged dataset. |
man/mpn_elite_usa.Rd |
Updates docs reflecting mode naming/layering for US elite datasets. |
man/mpn_elite_mex.Rd |
Updates docs reflecting stocnet-style node naming. |
man/mpn_bristol.Rd |
Updates docs reflecting stocnet conversion and mode naming. |
man/mpn_ryanair.Rd |
Updates docs reflecting stocnet conversion (node/tie field changes). |
Files not reviewed (2)
- man/make_play.Rd: Generated file
- man/mpn_bristol.Rd: Generated file
Suppressed comments (2)
R/model_diffusion.R:42
furrr::furrr_options(seed = T)uses the shorthand constantT, which can be overridden by user code (it’s just a variable) and is less robust thanTRUE. Useseed = TRUEto avoid accidental non-reproducibility.
if (inherits(.data, "stocnet")) .data <- manynet::as_igraph(.data)
out <- furrr::future_map_dfr(1:times, function(j){
data.frame(sim = j,
manynet::as_diffusion(manynet::play_diffusion(.data, ...)))
}, .progress = verbose, .options = furrr::furrr_options(seed = T))
R/data_mpn.R:527
- Typo in author name in the
@referenceslist below: “Nordstron” should be “Nordstrom” (Pevehouse et al. 2020).
#' @rdname mpn_cow_separate
#' @usage data(mpn_cow_igo)
#' @source
#' The Correlates of War Project. 2019. \emph{Intergovernmental Organization v3}.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| \if{html}{\out{<div class="sourceCode">}}\preformatted{#> -- # Senate contribution and voting network ------------------------------------ | ||
| #> # A labelled, undirected network of 196 senators and 5861 contribution and vote | ||
| #> ties |
| \if{html}{\out{<div class="sourceCode">}}\preformatted{#> -- # Bristol protest event network --------------------------------------------- | ||
| #> # A labelled, two-mode network of 150 individuals and 114 individuals and 1496 | ||
| #> affiliation and participation ties | ||
| #> # A labelled, undirected network of 264 individuals and 1496 affiliation and | ||
| #> participation ties |
| \if{html}{\out{<div class="sourceCode">}}\preformatted{#> -- # US power elite network ---------------------------------------------------- | ||
| #> # A labelled, multiplex, undirected network of 38 elites and 59 board | ||
| #> membership ties and 44 campaign contribution ties | ||
| #> |
| \if{html}{\out{<div class="sourceCode">}}\preformatted{#> -- # Senate community A -------------------------------------------------------- | ||
| #> # A labelled, undirected network of 114 senators and 2791 contribution and vote | ||
| #> ties |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 61.17% 61.74% +0.57%
==========================================
Files 9 10 +1
Lines 716 732 +16
==========================================
+ Hits 438 452 +14
- Misses 278 280 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…package_version()`
Package
Models
play_diffusions()forstocnetinput via initial coercion (re play_diffusion() stops on stocnet input, including manynet's own datasets manynet#172)Data
mpn_*dataset to thestocnetclass, in line with{manynet}weighttie attribute from the datasets that are not weightedmpn_cowof 116 "states" and 40 "IGOs", with
tradeandmembershiptie layersmpn_cow_tradeandmpn_cow_igoare retained, because{manynet}currentlyreads a network with two named modes as undirected, which symmetrises the
trade layer of
mpn_cow, and becauseto_layer()does not recover that layereither (to_layer() corrupts arc endpoints when it drops nodes manynet#170, is_directed() returns FALSE for a two-mode network with a directed layer manynet#171)
mpn_cow_trademissing-data coding from-9(759 cells) toNAscopenode attribute to the IGOs inmpn_cowandmpn_cow_igo,recording whether an organisation is
"global"or"regional"mpn_senateof 93 senators, 78 PACs, and 25 bills
mpn_senate_demandmpn_senate_repare not party networks butrecord two communities of one network and their intersection;
the
communitynode attribute holds"A","B", or"both"missing rather than as absent ties
community A governs, since it agrees with the overlap file in all 640
mpn_senate_dem,mpn_senate_rep, andmpn_senate_overare deprecated andwill be removed in 1.8.0
mpn_evs_ita,mpn_evs_deu, andmpn_evs_gbrwith the year recorded in the
timetie attributeover_time()notover_waves()mpn_elite_mexmpn_elite_usa_advice"directors"and"think tanks"mpn_elite_usa_money"elites","organisations", and"candidates"mpn_bristol"individuals","organisations", and"events"mpn_ryanair