Skip signature feature tests when esig is unavailable - #4
Merged
steveya merged 2 commits intoMar 20, 2026
Merged
Conversation
Co-authored-by: steveya <7390489+steveya@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add CLAUDE.md project documentation
Skip signature feature tests when esig is unavailable
Mar 20, 2026
steveya
marked this pull request as ready for review
March 20, 2026 03:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI fails because
test_signature_features.pyhas no guard against the missingesigpackage, which sktime'sSignatureTransformerrequires at runtime. All 13 tests in the module error out withModuleNotFoundError.Change
Added
pytest.importorskip("esig")at module level intest_signature_features.py, consistent with the existingpytest.importorskip("alphaforge")pattern already present in the same file:This skips the entire module gracefully when
esigis not in the environment rather than failing.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.