Fix name mismatch on 14 - Build Pipeline.md - #4
Open
Claudiferock wants to merge 1 commit into
Open
Conversation
The current code sample in this documentation gives a different secret name ${{ secrets.BUCKET_ID }} to the one given during the workshop ${{ secrets.BUCKET_NAME }}
I referred to this readme when creating the secrets on GitHub and my test kept on failing, until I realized I used the wrong name. Hopefully this prevents others from having the same issue.
Claudiferock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix name mismatch
The current code sample on the readme documentation gives a different secret name
${{ secrets.BUCKET_ID }}to the one used during the workshop${{ secrets.BUCKET_NAME }}I referred to the readme when creating the secrets on GitHub and kept failing my tests, until I realized I used the wrong name 🙃 Hopefully this prevents others from having the same issue.