Repository navigation
Conversation
response_exception() slept for the context's response timeout, 500 ms by default, before flushing and sending every exception response. Any malformed request, an unknown function code included, therefore held the server for that long, and an unauthenticated peer can repeat it at will. Over TCP the MBAP header gives the length of the request and modbus_receive() has already read all of it, so there is nothing left to wait for. Keep the flush, and only sleep over RTU, where the delay lets the rest of a corrupted frame arrive before it is discarded. The unknown function code test now uses a response timeout shorter than the server's over TCP, so it fails if the server waits again. Refs stephane#874
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
response_exception() slept for the context's response timeout, 500 ms by default, before flushing and sending every exception response. Any malformed request, an unknown function code included, therefore held the server for that long, and an unauthenticated peer can repeat it at will.
Over TCP the MBAP header gives the length of the request and modbus_receive() has already read all of it, so there is nothing left to wait for. Keep the flush, and only sleep over RTU, where the delay lets the rest of a corrupted frame arrive before it is discarded.
The unknown function code test now uses a response timeout shorter than the server's over TCP, so it fails if the server waits again.
Refs #874