Skip to content

modbus: export the libmodbus_version_* variables from the DLL - #879

Open
yoyixms wants to merge 1 commit into
stephane:masterfrom
yoyixms:msvc-version-export
Open

yoyixms wants to merge 1 commit into
stephane:masterfrom
yoyixms:msvc-version-export

Conversation

@yoyixms

@yoyixms yoyixms commented Sep 23, 2026

Copy link
Copy Markdown

They were declared without MODBUS_API, so an MSVC build of modbus.dll did not export them and programs using them, such as tests/version.c, failed to link. MinGW builds did not notice thanks to auto-import.

They were declared without MODBUS_API, so an MSVC build of modbus.dll
did not export them and programs using them, such as tests/version.c,
failed to link. MinGW builds did not notice thanks to auto-import.
@cla-bot

cla-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: yoyixms.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@yoyixms
yoyixms force-pushed the msvc-version-export branch from 8a6cf0d to 53fef71 Compare September 28, 2026 01:23
@cla-bot

cla-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant