Repository navigation
Conversation
modbus_set_transport() overrides the backend send, recv, select, connect, close and flush with caller-provided callbacks, leaving the framing, CRC and protocol logic unchanged; NULL members fall back to the backend
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: yoyixms.
|
A transport following select(2) returns 0 when the timeout expires, but the receive loop only knew the backends' -1 with ETIMEDOUT, so it called recv() on an empty link and reported ECONNRESET, reconnecting when link error recovery was enabled. The transport contract is now documented.
On Windows the recovery code chose between reconnecting and flushing from WSAGetLastError(), which only the socket backend sets. A transport reports its errors through errno, so it was never reconnected. It now follows the errno rules on every platform, as documented for transports.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: yoyixms.
|
yoyixms
force-pushed
the
pluggable-transport
branch
from
September 28, 2026 01:23
206cbbf to
771dc09
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modbus_set_transport() overrides the backend send, recv, select, connect, close and flush with caller-provided callbacks, leaving the framing, CRC and protocol logic unchanged; NULL members fall back to the backend