Repository navigation
fix: implement issues #1138, #1139, #1140, #1141 - #1165
Open
devisgood24 wants to merge 1 commit into
Open
devisgood24 wants to merge 1 commit into
devisgood24 wants to merge 1 commit into
Conversation
…vtools#1139, stellarkit-lab-devtools#1140, stellarkit-lab-devtools#1141 - closes stellarkit-lab-devtools#1138: Add test coverage for GET /account/:id/self-payment-detection * Test direct self-payments return type: direct_self * Test 3-hop circular chains return type: circular_chain * Test normal payment history returns selfPaymentsDetected: false * Test chains longer than 10 hops are not flagged - closes stellarkit-lab-devtools#1139: Implement GET /account/:id/largest-transactions endpoint * Returns top N transactions by total operation value * Supports ?direction=sent|received|both * Limit parameter capped at 50 * Returns transaction hash, totalValueXLM, operationCount, timestamp - closes stellarkit-lab-devtools#1140: Add test coverage for GET /dex/order-book-depth * Test 3 bid levels return cumulative values correctly summed * Test spread computed as bestAsk - bestBid * Test ?depth=5 returns exactly 5 bid and 5 ask levels * Test OrderBookEmpty error when no orders exist - closes stellarkit-lab-devtools#1141: Create docs/pagination-patterns.md advanced guide * Sequential pagination with cursor resumption * Parallel pagination across multiple accounts * Detecting last page from hasMore and nextCursor * Recommended page sizes for different use cases * Complete Node.js example streaming all transactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test coverage for GET /account/:id/self-payment-detection
Implement GET /account/:id/largest-transactions endpoint
Add test coverage for GET /dex/order-book-depth
Create docs/pagination-patterns.md advanced guide
closes #1138
closes #1141
closes #1140
closes #1139