Repository navigation
Fix: 3 issues (#1018, #1027, #1028) - #1126
Merged
Sulex45 merged 2 commits intoOct 23, 2026
Merged
Conversation
Co-authored-by: Simple Agent <agent@simple.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1018
Closes #1027
Closes #1028
Issues
#1018 Write tests for POST /utils/decode-transaction with all common operation types
#1027 Write a docs/claimable-balances-guide.md explaining all claimable balance endpoints
#1028 Write tests for GET /account/:id/offer-exposure exposure aggregation and liquidity risk
Summary
The decode-transaction endpoint emits snake_case operation types (change_trust, manage_sell_offer, set_options) via toSnakeCaseType, so tests must assert those rather than the camelCase names in the issue text. XDR fixtures should be generated at test time with TransactionBuilder using Networks.TESTNET to stay valid. For offer-exposure tests, inspect the actual route in src/routes/account.js to confirm the exact response field names (sellingExposure, offerCount, liquidityRisk) and the 404 error path before writing assertions; mock server.offers().forAccount(...).call() and server.loadAccount accordingly. The claimable balances guide should reflect the real response shapes from src/routes/claimableBalances.js and the account claimable-balance routes.
Changes