Release pipeline hardening - #146
Merged
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens the release/publish pipeline by aligning pnpm versions across workflows, adding missing CI gates (typecheck/lint), and ensuring publishes can’t bypass the full build/verification suite.
Changes:
- Add
packageManager: pnpm@10.33.0and enforce aprepublishOnlygate running build/typecheck/lint/test. - Update CI to run on a Node 22/24 matrix and add explicit
typecheck+lintsteps. - Update npm publish workflow for Trusted Publishing (OIDC) and remove token-based auth.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Pins pnpm via packageManager, adds prepublishOnly gating, expands cleanup, and populates keywords. |
| .github/workflows/tests.yml | Adds Node 22/24 matrix and runs typecheck and lint in CI. |
| .github/workflows/npm-publish.yml | Updates actions, uses OIDC trusted publishing flow, and expands publish-time gates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
38
to
+41
| - name: Publish to npm | ||
| run: pnpm publish --access public --provenance --no-git-checks --tag ${{ github.event.release.prerelease && 'rc' || 'latest' }} | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| run: | ||
| pnpm publish --access public --provenance --no-git-checks --tag ${{ | ||
| github.event.release.prerelease && 'rc' || 'latest' }} |
Comment on lines
+18
to
+25
| - name: Install pnpm | ||
| # Version comes from the packageManager field in package.json. | ||
| uses: pnpm/action-setup@v4 | ||
|
|
||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| version: 10 | ||
| node-version: ${{ matrix.node-version }} |
Comment on lines
16
to
24
| - name: Install pnpm | ||
| # Version comes from the packageManager field in package.json. | ||
| uses: pnpm/action-setup@v4 | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '22.x' | ||
| registry-url: 'https://registry.npmjs.org' |
quietbits
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the publish pipeline and add missing CI gates
The publish workflow was likely broken (pnpm 9 pinned against
engines >=10),and nothing anywhere ran the type checker.
packageManager: pnpm@10.33.0— both workflows now letpnpm/action-setupread it instead of pinning divergent inline versions,fixing the publish job's engines mismatch.
prepublishOnlygate —build && typecheck && lint && testruns on anypublish, so a stale or untested
dist/can't ship from a local machine.typecheckandlint— vitest transpiles with esbuild, whichstrips types without checking them; type errors could previously merge green.
Also adds a Node 22/24 matrix and bumps actions to v4.
redundant
NPM_TOKEN(the job already hadid-token: write+--provenance). Requires the repo to be registered as a trusted publisherfor
@stellar/js-xdron npmjs.com before the next release.cleanalso removes the stale v4lib/bundle; npmkeywordspopulated.