Repository navigation
docs: reconcile Error Reference table with contract Error enum - #617
Merged
techisigu merged 6 commits intoOct 24, 2026
Conversation
added 3 commits
October 22, 2026 11:47
Adds a public view function to the governor contract for issue stellar-vortex-protocol#532. This read-only function returns the current including: - registry: Address of the solver registry - timelock: Address of the timelock controller - voting_delay: Delay before voting starts - voting_period: Duration of the voting period - proposal_threshold: Minimum voting power to create a proposal - quorum: Minimum total votes for a proposal to succeed Useful for off-chain tooling, dashboards, and governance UI. Closes stellar-vortex-protocol#532
Adds a public view function for issue stellar-vortex-protocol#533. Returns the withdrawal cooldown expiration timestamp for an LP: - 0 if no cooldown is set (cooldown expired or LP never deposited) - Future timestamp if cooldown is active (LP must wait until this timestamp) This enables off-chain tooling and dashboards to display accurate cooldown status for LPs without requiring them to track deposit times locally. Closes stellar-vortex-protocol#533
Updates the README's Error Reference table to include all variants from the intent_settlement Error enum (codes 37-113+). Addresses issue stellar-vortex-protocol#531 by adding missing variants: - Bid/window errors (37-50) - Dispute/escrow errors (51-54) - Batch/backstop errors (55-58) - Oracle errors (59-63) - Intent lifecycle errors (63-66) - Policy/operator errors (67-74) - Proof-gated fill errors (75-80) - Self-referral and config errors (81-86) - Migration/bid errors (87-105) - Backstop/exposure errors (106-108) - Additional oracle errors (109-113) Also adds a note about duplicate discriminant values in the enum. Closes stellar-vortex-protocol#531
|
@gabrielujelistic-collab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…flicts (Simple agent) - governor/src/lib.rs: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
…flicts (Simple agent) - README.md: merged [markers] — model resolved the conflict markers - governor/src/lib.rs: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
…flicts (Simple agent) - governor/src/lib.rs: merged [markers] — model resolved the conflict markers Co-authored-by: Simple Agent <agent@simple.dev>
techisigu
merged commit Oct 24, 2026
6c08002
into
stellar-vortex-protocol:main
0 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the README's Error Reference table to include all variants from the intent_settlement Error enum, addressing issue #531.
Changes
Added missing variants (codes 37-113+) to the Error Reference table:
Also adds a note about duplicate discriminant values in the enum (e.g.,
AmountTooLargeandIntentNotTerminalboth use code 36).Testing
Documentation-only change.
Closes #531