Repository navigation
feat: arbiter panel, directory, oracle wiring, client-computable intent ids - #601
Merged
Conversation
…nt ids Closes stellar-vortex-protocol#565 Closes stellar-vortex-protocol#555 Closes stellar-vortex-protocol#554 Closes stellar-vortex-protocol#549 - intent_settlement: timestamp-free compute_intent_id, get_user_nonce, preview_intent_id (stellar-vortex-protocol#565) - arbiter_panel contract; set_arbiter_panel + dispute_parties; resolve_dispute gated by configured arbiter; design doc corrected (stellar-vortex-protocol#555) - directory address-book contract + design note (stellar-vortex-protocol#554) - declare mod oracle; weight cross-token exposure by oracle price with fail-closed fallback (stellar-vortex-protocol#549)
|
@knytcomics-ui Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
techisigu
merged commit Oct 24, 2026
7c9c4e2
into
stellar-vortex-protocol:main
0 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #565
Closes #555
Closes #554
Closes #549
Summary
compute_intent_idstill requires a timestamp #565compute_intent_idno longer hashes the timestamp; implements thedocs/CLIENT_COMPUTABLE_INTENT_IDS.mdscheme (domain sep + contract id + network id + user + nonce + params hash). Addsget_user_nonce/preview_intent_id, regression test, CHANGELOG entry.arbiter_panel) contract — closed issue #407 delivered a design-doc rewrite, not code, andresolve_disputestill runs on plain admin authorization #555 Newarbiter_panelcrate (bonded registration, PRNG panel selection,open_vote/vote/tally, slashing,VOTE_WINDOWtimeout).intent_settlementgetsset_arbiter_panel+dispute_parties;resolve_disputeis gated by the configured arbiter (the panel once set). Design doc corrected: the legacy admin-arbiter applies untilset_arbiter_panelis called.directory) contract — closed issue #399 delivered zero source code #554 Newdirectorycrate (admin-updatable name -> address registry, two-step admin rotation, TTL bumps) +docs/directory-design.md.intent_settlement/src/oracle.rsinto the contract — it is currently dead code #549mod oracle;declared,#![allow(unused)]removed; cross-token exposure inaccept_intent/fill_intent/slash_solverweighted by oracle price with fail-closed 1.0x fallback; oracle calls usetry_so slashing is never blocked.Validation
cargo test -p vortex-arbiter-panel -p vortex-directory: 9 + 5 tests pass.oracle.rsand the newcompute_intent_idcompiled and tested in an isolated scratch crate (oracle fail-closed tests pass).intent_settlementitself. Onmainit does not compile (pre-existing, unrelated):proof_registryhas 8 errors, andintent_settlement/src/lib.rshas duplicate constants/enum variants/resolve_disputedefinitions. I did not touch those. My settlement edits (and the new tests intest.rs/test_oracle.rs) are therefore uncompiled in situ.Cargo.lockwas refreshed (cargo update -p ed25519-dalek@3.0.0) because the committed lock pulled aed25519-dalek3.0.0 that breakssoroban-env-hosttest builds.