feat: Add Xiaomi MiMo prepaid balance provider#1309
Conversation
New provider (.mimobalance) shows cashBalance (Paid) and giftBalance (Granted) from MiMo API alongside the existing token plan provider. Displays in menubar and menu card following DeepSeek balance pattern.
|
Codex review: needs changes before merge. Reviewed June 5, 2026, 1:25 AM ET / 05:25 UTC. Summary Reproducibility: yes. for the review finding: source inspection shows the docs use Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Copy recommended automerge instructionNext step before merge
Security Review findings
Review detailsBest possible solution: Fix the CLI docs or alias mismatch, then have maintainers explicitly accept the new disabled-by-default provider and shared MiMo cookie-auth behavior. Do we have a high-confidence way to reproduce the issue? Yes for the review finding: source inspection shows the docs use Is this the best way to solve the issue? Not quite yet: the provider implementation follows existing MiMo and balance-provider patterns, but the documented CLI path must match the registered CLI name or alias before merge. The shared-cookie provider behavior also needs maintainer sign-off because it changes auth-provider surface. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 65e39f4dcb3a. Label changesLabel changes:
Label justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
frozenBalance, overdraftLimit, and remainingOverdraftLimit can be null in the API response. Make them optional so JSONDecoder does not reject valid payloads. Add focused parser tests with null and full-field fixtures.
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Behavior proof: MiMo Balance provider successfully fetching and displaying prepaid balance with paid/granted breakdown. Balance shows $9.60 total (Paid: $9.60 / Granted: $0.00).
@clawsweeper re-review |
|
🦞👀 Command router queued. I will update this comment with the next step. Re-review progress:
|
MiMo Balance now reuses the existing MiMo token-plan cookie settings instead of maintaining its own separate auth surface. The MiMoBalanceWebFetchStrategy reads from the .mimo cookie cache and settings, eliminating the duplicate credential path. Currency formatting uses UsageFormatter.currencyString with the API's currency code instead of hardcoding $/¥ symbols.
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
CLI snapshot for .mimobalance now populates .mimo settings so the fetch strategy reads the shared MiMo auth state. Menubar balance extractor no longer requires $ or ¥ prefix — splits on space to work with any currency.
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Replace empty options array with functional picker bound to shared MiMo cookie settings. Users who enable only the balance provider can now configure cookie source (Auto/Manual) directly.
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|

Adds a new .mimobalance provider (Alibaba-style separate provider pattern) that shows MiMo prepaid API balance with Paid/Granted breakdown.