fix: use Cursor app auth as fallback#1295
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 4, 2026, 2:08 AM ET / 06:08 UTC. Summary Reproducibility: not applicable. This PR adds a new Cursor auth fallback rather than reporting a reproducible current-main bug. The PR body provides redacted live output for the new path, and source inspection confirms current main lacks it. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge only after maintainer sign-off that Cursor.app local bearer auth is an acceptable last-resort Cursor source; otherwise require an explicit opt-in path before enabling it for existing users. Do we have a high-confidence way to reproduce the issue? Not applicable; this PR adds a new Cursor auth fallback rather than reporting a reproducible current-main bug. The PR body provides redacted live output for the new path, and source inspection confirms current main lacks it. Is this the best way to solve the issue? Unclear pending maintainer policy: if Cursor.app local bearer auth is acceptable, placing it after existing cookie/session sources is the narrowest maintainable implementation. If silent fallback to the app account is not acceptable, an explicit opt-in source is safer. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 65e39f4dcb3a. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69bf8e7407
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Thanks for the automated review — both points were valid and are addressed in Changes:
Validation:
|
|
@clawsweeper re-review Addressed the code findings:
Validation is in the PR body. Live provider proof is still not run here because AGENTS.md requires an explicit request before real credential/provider probes. |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review Please review current head |
|
🦞👀 Command router queued. I will update this comment with the next step. Re-review progress:
|
|
@clawsweeper re-review Added redacted live Cursor.app local-auth proof to the PR body for current head Proof summary:
|
|
🦞👀 Command router queued. I will update this comment with the next step. Re-review progress:
|
Summary
Test Plan
swift test --filter CursorStatusProbeTests— 31 tests passedmake checkswift test— 3241 tests passedLive Proof
148048d3d9887e94279653e80a58450246867a7con 2026-06-04.CodexBarCoreinternals:CursorAppAuthStore().loadSession()read Cursor.appstate.vscdb.CursorStatusProbe.fetchWithAppAuthSession(_:)fetched DashboardService usage/account data.