docs(cli): document serve request timeout#1278
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 2, 2026, 9:42 AM ET / 13:42 UTC. Summary Reproducibility: not applicable. as a bug reproduction. Source inspection on current main shows Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow help/test update after the contributor adds real terminal proof of the changed CLI help, or after a maintainer intentionally waives that proof for this low-risk docs/help change. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction. Source inspection on current main shows Is this the best way to solve the issue? Yes, the proposed direction is the narrow maintainable fix for the observed docs/help gap. It updates the custom help strings and covers them with a focused test without changing serve runtime behavior. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 0ebb5043a071. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary\n- Include --request-timeout in codexbar serve help output\n- Add a regression test covering serve/root help text\n\n## Testing\n- swift test --filter CLIServeRouterTests