Add Devin usage provider#1264
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 1, 2026, 3:32 AM ET / 07:32 UTC. Summary Reproducibility: not applicable. This PR adds a new provider capability rather than reporting a broken existing behavior. I did source and diff review, and avoided live browser/provider probes because the repository policy requires explicit request for validation that can touch real accounts or prompts. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land a narrow Devin provider after auth/privacy sign-off, preserving the normalized widget project reference and adding redacted live Devin quota-fetch proof to the PR. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR adds a new provider capability rather than reporting a broken existing behavior. I did source and diff review, and avoided live browser/provider probes because the repository policy requires explicit request for validation that can touch real accounts or prompts. Is this the best way to solve the issue? Unclear: adding Devin fits the provider direction, but this branch is not yet the best merge path until auth/privacy sign-off, inspectable real behavior proof, and the widget project metadata cleanup are handled. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 4756ba06bf42. Label changesLabel changes:
Label justifications:
Evidence reviewedSecurity concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Add a web-backed Devin provider with browser-session import, organization discovery, quota parsing, settings UI, widget/config registration, and regression coverage. Refresh expired Auth0 browser access tokens before retrying quota fetches and present Devin as a web source instead of a missing CLI. Closes: steipete#800
25ebbb4 to
94a4a3e
Compare
Summary
Fixes #800
Verification
swift test --filter DevinUsageFetcherTestsswift test --filter ProviderSettingsDescriptorTestsmake checkCODEXBAR_SIGNING=adhoc ./Scripts/package_app.shCodexBar.app; logs showed expired token refresh followed by successful quota fetch