fix(e2e): update diary-r2-uat tests for manual-default diary filter#1790
Merged
Conversation
Diary default changed from 'all' to 'manual' in #1782. Three test scenarios in diary-r2-uat.spec.ts were asserting the old default ('All' chip pressed) or trying to click 'Manual' when it was already active (causing timeout). Co-Authored-By: Claude e2e-test-engineer (claude-sonnet-4-6) <noreply@anthropic.com> Co-Authored-By: Claude dev-team-lead (claude-sonnet-4-6) <noreply@anthropic.com>
This was referenced Jun 28, 2026
Contributor
|
🎉 This PR is included in version 2.12.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three E2E test scenarios in
diary-r2-uat.spec.tswere broken by the diary default filter change in #1782.Root cause: #1782 changed the diary page default filter from
'all'to'manual'. Three tests were left asserting the old default behavior:"All" mode chip is aria-pressed=true by default) — assertedallChippressed; nowmanualChipis pressed by defaultClicking "All" after "Manual" restores all type chips) — first clicked Manual (already active = no API call,waitForResponsetimeout)Selecting "Manual" mode sends only manual types to API) — clicked Manual when already in Manual mode (no API call, timeout)Fix: Updated all three scenarios to work with the new
manualdefault — Scenario 1 renamed and assertions flipped; Scenario 4 simplified to start from the new default; Scenario 10 adds an "All" click first to set a known state before switching to Manual.Fixes CI failure on promotion PR #1789.
Co-Authored-By: Claude e2e-test-engineer (claude-sonnet-4-6) noreply@anthropic.com
Co-Authored-By: Claude dev-team-lead (claude-sonnet-4-6) noreply@anthropic.com