Repository navigation
fix(browser): parse flags after text values and fail on missing sessions - #115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fill,type,setvalueandset useragentcaptured every argument after the value, including--session. The command then ran on thedefaultsession. If no default daemon was running, the CLI silently started a new cloud session. Agents saw "Unknown ref" or a blank page while their real session sat idle.trailing_var_argfrom the four value args. Flags now parse anywhere, and unquoted multi-word values still work.--session <name>no longer starts a new session when its daemon is not running. It fails and suggestssteel browser start --session <name>. This also covers sessions that expired or idled out. Those used to come back silently with default settings.defaultsession prints a warning to stderr, also in JSON mode.