Transition to Official Go Implementation #44

Activity

1. erikist

   added

   notreadyNot ready for implementationNot ready for implementation

   on May 7, 2025
2. erikist commented on May 15, 2025

   

   erikist

   on May 15, 2025

   ContributorAuthor

   More actions

   https://pkg.go.dev/golang.org/x/tools/internal/mcp#pkg-index
3. erikist commented on May 15, 2025

   

   erikist

   on May 15, 2025

   ContributorAuthor

   More actions

   Going to create a long term release branch for this -- official-go-mcp
4. erikist

   removed

   notreadyNot ready for implementationNot ready for implementation

   on May 15, 2025
5. erikist

   added sub-issues on Oct 8, 2026

   • test: golden-file test for the plugin's generated code #85
   • chore: remove the stale snapshot and hand-written example; run mcp-vibe on generated code #86
   • test: end-to-end test of a generated MCP server (gRPC backend + MCP client) #87
   • feat: generate JSON Schema for tool inputs from proto descriptors (protojson-compatible) #88
   • feat!: generate MCP servers on the official Go MCP SDK #89
   • ci: fail when generated examples are out of date #90
   • docs: document the official-SDK API and 0.3.0 upgrade notes #91
6. erikist

   added this to the v0.3.0: official Go MCP SDK milestone on Oct 8, 2026
7. erikist commented on Oct 8, 2026

   

   erikist

   on Oct 8, 2026

   ContributorAuthor

   More actions

   🔍 Plan (Claude, on behalf of @erikist). The migration target is github.com/modelcontextprotocol/go-sdk v1.8.0, the stable official SDK (it requires Go 1.25). The work lands as small PRs on main, and release-please cuts 0.3.0. These sub-issues are in the "v0.3.0: official Go MCP SDK" milestone, and dependencies are set:

   #	What	Blocked by
   #85	Golden-file test for generated code
   #86	Remove the stale snapshot and hand-written example; mcp-vibe uses the generated code (part of #46)
   #87	End-to-end test: fake gRPC backend plus an in-process MCP client, written against today's output	#86
   #88	JSON Schema from proto descriptors, protojson-compatible
   #89	The migration (feat!)	#85, #87, #88
   #90	CI: fail when generated examples are out of date	#85
   #91	Docs and 0.3.0 upgrade notes	#89

   Key decisions:

   • Schemas from descriptors. The official SDK validates arguments against each tool's input schema, and mark3labs never did. Today's schemas nest arguments under the message name while the handler reads them from the top level, and they drop repeated, enum and most numeric fields. So schemas are built from the proto descriptors to match exactly what protojson.Unmarshal accepts (feat: generate JSON Schema for tool inputs from proto descriptors (protojson-compatible) #88).
   • Tests first. The tests land before the migration, so it can be checked against current behaviour.

   The work will be done by an sf-factory agent factory, with PRs reviewed and approved by a human. Draft #74 (against the pre-release x/tools/internal/mcp) is superseded; its typed-handler idea carries into #89.
8. erikist

   added a sub-issue on Oct 8, 2026

   • fix: escape proto comments correctly in generated descriptions and schemas #100
9. erikist commented on Oct 8, 2026

   

   erikist

   on Oct 8, 2026

   ContributorAuthor

   More actions

   🔍 Done (Claude, on behalf of @erikist). Generated servers now use the official github.com/modelcontextprotocol/go-sdk v1.8.0, and mark3labs is gone. Every PR was written by an sf-factory agent factory and reviewed before merge.

   Issue	PR	What
   #86	#94	Removed the stale snapshot and hand-written example; mcp-vibe runs on generated code
   #85	#96	Golden-file test of generated code (no protoc needed)
   #87	#95	End-to-end test: fake gRPC backend plus an in-process MCP client
   #90	#97	CI fails when generated examples are stale. The toolchain is pinned, including Go 1.27.1, which turned out to cause the comment-format drift
   #88	#98	JSON Schema from proto descriptors, protojson-compatible. Covers recursion, NaN/Infinity and Any, and was validated against a real go-sdk server
   #89	#99	The migration (feat!), with a BREAKING CHANGE footer
   #100	#101	Comment escaping in descriptions and schemas
   #91	#102	README and CONTRIBUTING: official-SDK wiring (stdio and Streamable HTTP), how arguments map, and 0.2.x → 0.3.0 upgrade notes

   Behaviour changes for users:

   • Schemas: tool input schemas now accurately describe the request message, and the SDK validates arguments against them.
   • Arguments and results: both are protojson (lowerCamel names).
   • Errors: gRPC errors come back as isError results, with the status code.

   The release PR, #84 (0.3.0), is ready for a human to cut. #93 tracks restoring 1 required approval on main.
10. erikist

    closed this as completedon Oct 8, 2026