Skip to content

docs: every commit and push is asked for first - #45

Merged
lloydsk merged 1 commit into
mainfrom
docs/commit-permission-rule
Sep 29, 2026
Merged

lloydsk merged 1 commit into
mainfrom
docs/commit-permission-rule

Conversation

@lloydsk

@lloydsk lloydsk commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

What

Adds the permission rule to docs/releasing.md, and the two rules that a damaged file taught.

Nothing is committed or pushed without the owner's permission — every change, every time, with no exemptive category. Approval of the work is not approval to land it, and a green CI check is not an instruction. Agent briefs must say "propose, do not commit", because a brief ending "commit and push" overrides the rule by accident — which is exactly how the agent-driven work in this repository was operating.

Recorded alongside it, because they caused real damage: a failed edit can still truncate the file it targeted, and a path must never be staged on the strength of intending to change it. Both happened here — a method.md was emptied by an edit that reported no match, then committed because it was staged on intent.

Why it belongs in this repo

The repository's own conventions document is docs/releasing.md, which already covers how changes reach main and how releases are cut. A rule about not committing without permission is the same kind of convention, and it governs the workflow every contributor and agent here uses.

Checks

Documentation only — no runtime surface. bun run lint:pr-title passes on this title.

Nothing is committed or pushed without the owner's permission - every change, every time, with no
exemptive category. Approval of the work is not approval to land it; a green check is not an
instruction. Agent briefs must say 'propose, do not commit', since a brief ending 'commit and push'
overrides the rule by accident.

Also records the two rules a damaged file taught: an edit that fails can still truncate the file it
targeted, and a path must never be staged on the strength of intending to change it.
@github-actions

Copy link
Copy Markdown
Contributor

CI report

Check Result
tsc --noEmit success
tests success
npm pack --dry-run success (7 files in tarball)

Ref: b26e3ed98c560bccf8b9326dd908c818621b9fef

@lloydsk
lloydsk merged commit e344218 into main Sep 29, 2026
2 checks passed
@lloydsk
lloydsk deleted the docs/commit-permission-rule branch September 29, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant