fix/send to microreact returns status 500 - #307
Open
svj-contextand wants to merge 1 commit into
Open
Conversation
svj-contextand
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
analysis.py/get_single_analysis(), as bio-api still depends on it.workspaces.py/get_workspace()by callingget_single_analysis_by_object_id()directly.MicroreactController.py.Background
In PR #288,
get_single_analysis_by_object_id() was changed to call and returnget_single_analysis(), which suppresses the MongoDB _id (seemingly as part of the transistion to use sequence_id internally).However, bio-api still requires the MongoDB _id, so suppressing it caused it to fail.
Notes
The ID string conversion in
MicroreactController.pymay be unnecessary, but I have not been able to verify this locally because bio-api is currently unavailable in the local environment. The original error is no longer reproducible on my end.