Patch obvious missing tests - #291
Draft
RasmusSkytte wants to merge 21 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
===========================================
+ Coverage 64.17% 78.83% +14.65%
===========================================
Files 28 27 -1
Lines 9597 4483 -5114
===========================================
- Hits 6159 3534 -2625
+ Misses 3438 949 -2489 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…if no option is given
RasmusSkytte
force-pushed
the
test/improve-test-coverage
branch
from
August 27, 2026 13:01
eb3e092 to
8498c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
This PR adds simple tests for the parts of our code base that is not covered by tests.
This is not intended to imply that this code is well-tested, but it will introduce a minimum level of testing for this code
Approach
Tests added / modified:
DiseasyRegions$plot()is tested to not produce errorsDiseasyActivity$plot()is tested to not produce errorsDiseasyImmunity$describe()is tested to not produce errorshash_environment()wraps the error-inputs in lists to correctly mimic the how errors would be passed to the function. The current implementation of the tests was wrong and some code would not be reached in the tests.combineasy()DiseasyImmunity$approximate_compartmental()exponential_waningnow actually useexponential_waning.In addition:
.covrignoreadded to not flag missing coverage in our linters (since these are only for developers)Known issues
N/A
Checklist
NEWS.md