Skip to content

A helper to generate the example model - #290

Open
RasmusSkytte wants to merge 7 commits into
mainfrom
feature/generator-for-example-model
Open

A helper to generate the example model#290
RasmusSkytte wants to merge 7 commits into
mainfrom
feature/generator-for-example-model

Conversation

@RasmusSkytte

@RasmusSkytte RasmusSkytte commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Intent

This PR fixes a pain point whenever we modify the example model used to generate the data for DiseasySeirExample which we use -- among other things -- to test our modelling framework.

When we modify this model, we need to find all places in the tests that uses / modifies this model in their own tests and this is can be a rather annoying process.

Approach

A un-exported function generate_example_seir_model() was created to produce the model used in the example data.

This function has overrides to change parameters or modules to allow the tests to create small variations of this model in their tests.

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte
RasmusSkytte force-pushed the feature/generator-for-example-model branch from d2f8b6d to 3697f7e Compare August 26, 2026 09:32
@RasmusSkytte
RasmusSkytte force-pushed the feature/generator-for-example-model branch from 93b63f0 to be0ef3f Compare August 26, 2026 10:06
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.41%. Comparing base (6c1fcdd) to head (4c03a5b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   64.17%   64.41%   +0.23%     
==========================================
  Files          28       29       +1     
  Lines        9597     9661      +64     
==========================================
+ Hits         6159     6223      +64     
  Misses       3438     3438              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RasmusSkytte RasmusSkytte self-assigned this Aug 26, 2026
@RasmusSkytte
RasmusSkytte requested review from a team, LasseEngboChr, SofiaOtero and kaare-gr and removed request for a team August 26, 2026 13:44
@RasmusSkytte
RasmusSkytte marked this pull request as ready for review August 26, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant