Skip to content

refactor: Move map_population to DiseasyPopulation - #286

Open
RasmusSkytte wants to merge 5 commits into
mainfrom
refactor/move-map_population_to_DiseasyPopulation
Open

refactor: Move map_population to DiseasyPopulation#286
RasmusSkytte wants to merge 5 commits into
mainfrom
refactor/move-map_population_to_DiseasyPopulation

Conversation

@RasmusSkytte

@RasmusSkytte RasmusSkytte commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Intent

This PR is a stepping stone for implementing contact matrices per region.

Here we refactor the code to move the map_population from DiseasyActivity to DiseasyPopulation

Approach

map_population is moved without changes but some extra temporary changes and passing of variables had to be introduced in functions that depended on it.

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte added this to the DiseasyRegions milestone Aug 17, 2026
@RasmusSkytte RasmusSkytte self-assigned this Aug 17, 2026
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.39785% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.77%. Comparing base (00ab653) to head (f85eb91).

Files with missing lines Patch % Lines
R/DiseasyActivity.R 33.33% 4 Missing ⚠️
R/DiseasyPopulation.R 96.47% 3 Missing ⚠️
R/DiseasyModelOde.R 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   63.83%   63.77%   -0.07%     
==========================================
  Files          28       28              
  Lines        9585     9593       +8     
==========================================
- Hits         6119     6118       -1     
- Misses       3466     3475       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RasmusSkytte
RasmusSkytte marked this pull request as ready for review August 17, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant