refactor: Move map_population to DiseasyPopulation - #286
Open
RasmusSkytte wants to merge 5 commits into
Open
Conversation
5 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 63.83% 63.77% -0.07%
==========================================
Files 28 28
Lines 9585 9593 +8
==========================================
- Hits 6119 6118 -1
- Misses 3466 3475 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RasmusSkytte
marked this pull request as ready for review
August 17, 2026 10:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
This PR is a stepping stone for implementing contact matrices per region.
Here we refactor the code to move the
map_populationfromDiseasyActivitytoDiseasyPopulationApproach
map_populationis moved without changes but some extra temporary changes and passing of variables had to be introduced in functions that depended on it.Known issues
N/A
Checklist
NEWS.md