Skip to content

Update bcftools.yaml to remove gsl dependency comment - #222

Open
KasperThystrup wants to merge 6 commits into
devfrom
env_cleanup
Open

Update bcftools.yaml to remove gsl dependency comment#222
KasperThystrup wants to merge 6 commits into
devfrom
env_cleanup

Conversation

@KasperThystrup

@KasperThystrup KasperThystrup commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Description

Cleaning up in the environment files

  • Removed gsl dependency comment in bcftools.yaml as bcftool pkg now includes correct libraries

Type of Change

Add a label to this PR by commenting one of the following:

  • /build - Minor documentation or general repository. These changes will not increment the software version upon successful merge
  • /patch - Bugfixes and typos
  • /minor - New features and software enhancements
  • /major - Backwards incompatible changes (collaborators only)

Note: The label check waits 20 seconds before reading labels. Comment your label immediately after creating the PR to ensure the check passes.

Checklist

Before creating a Pull request for your changes, you can save time by completing the following steps in advance, on you local repository.

Special case

  • I'm ONLY doing changes to Github actions and/or Documentation
  • I've added the build label to my PR and I will Skip all tasks below!

Setup (Required for all PRs)

  • I have installed the local branch (e.g. using pip install . in an appropriate virtual environment)

For Adding or Removing Modules

  • I have added my new module to / removed the old module from - the appropriate .smk file:
    • PR_analysis.smk for paired-end reads
    • SR_analysis.smk for single-end reads
    • analysis.smk for assembly-based analysis
  • I have checked that the rule Output follows correct file naming conventions
  • I have created/updated the appropriate species config in mmaseq/src/mmaseq/config/species_configs/
  • I have added/removed the module alongside its configuration to both test.yaml and all.yaml
  • I have included a sample and added its ftp link to mmaseq/src/mmaseq/data/reads/reads.urls
  • I have updated the samplesheet at mmaseq/src/mmaseq/data/samplesheet.tsv (if needed)
  • I have run a minimal test using mmadeploy --test and confirmed that my module completed succesfully
  • I have added the minor label to my PR

For other pipeline Changes

  • I have that all my changes work using mmadeploy --update
  • I have added the patch OR minor label (depending on the type of changes) to my PR

Related Issues

@KasperThystrup KasperThystrup added the patch Automatic versioning label: v?.?.X Used for bug fixing and typos etc. label Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Automatic versioning label: v?.?.X Used for bug fixing and typos etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant