fs/internal/imptest: drop the stale skip note on ErrWalk - #182
Merged
Conversation
The ErrWalk doc says the subtest using the fixture is "skipped pending #165", so the fixture is built and not run. Neither half is true: #165 is closed, and "walk errors are delivered and terminate iteration" has no skip -- it runs the fixture on both backends. Only the sentence describing what the fixture is stays. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BqVx31tJdcFRWtVewGc2ez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ErrWalk doc says the subtest using the fixture is "skipped pending
#165", so the fixture is built and not run. Neither half is true: #165 is
closed, and "walk errors are delivered and terminate iteration" has no
skip -- it runs the fixture on both backends. Only the sentence describing
what the fixture is stays.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01BqVx31tJdcFRWtVewGc2ez