fs: fix fileWalk nil-deref on an error-yielding DirEntries - #179
Merged
Conversation
fileWalk fell through to e.Name() and e.Info() after yielding a nil entry's error, panicking on any error-yielding DirEntriesFS -- which DirEntriesFS's own contract permits and ocflfs.DirEntries produces whenever fsys isn't a DirEntriesFS. Continue after each error yield instead, and skip a nil entry paired with a nil error defensively. Unskipping the regression tests this unblocks also exposed that local.FS.DirEntries didn't normalize the Op/Path on a ReadDir error the way it does for Open's, so a listing failure leaked the absolute OS path instead of the name the caller passed in. Fixed alongside, since it's the same walk-error contract the unskipped tests assert. Fixes #173.
The trailing sentence tracked which of the doc's skip examples had already landed (#163, #173) versus which was still open (#166). With #173 now fixed alongside this package's own skip removal, the note is stale history rather than documentation of current behavior -- the #166 example above it already says everything a reader needs.
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fileWalk fell through to e.Name() and e.Info() after yielding a nil
entry's error, panicking on any error-yielding DirEntriesFS -- which
DirEntriesFS's own contract permits and ocflfs.DirEntries produces
whenever fsys isn't a DirEntriesFS. Continue after each error yield
instead, and skip a nil entry paired with a nil error defensively.
Unskipping the regression tests this unblocks also exposed that
local.FS.DirEntries didn't normalize the Op/Path on a ReadDir error
the way it does for Open's, so a listing failure leaked the absolute
OS path instead of the name the caller passed in. Fixed alongside,
since it's the same walk-error contract the unskipped tests assert.
Fixes #173.