fs: correctness fixes and cross-backend contract tests for the local and s3 backends - #161

Closed

exe-dev-github-integration[bot] wants to merge 67 commits into

mainfrom

Commits on Aug 24, 2026

s3: add DeleteObjects to RemoveAllAPI interface and mock
exe.dev user
committed
38a523c
fs: replace dstFS == srcFS comparison with SameBackend interface
exe.dev user
committed
50d7c87
fs/s3: add regression test for HeadObject 404 mapping to fs.ErrNotExist
exe.dev user
committed
3b7d7ee
fs/s3: pick MultiCopier from HEAD ContentLength instead of error text
exe.dev user
committed
96c529a
fs/local: implement SameBackend for local FS
exe.dev user
committed
dd2191a
fs/s3: batch object deletion per page in removeAll
exe.dev user
committed
1c5fbe5
fs/s3: implement SameBackend for BucketFS
exe.dev user
committed
a331772
fs/s3: add tests for batch delete in removeAll
exe.dev user
committed
6f04402
fs/local: pin Write ctx-cancel, deadline-exceeded and traversal-rejection errors
exe.dev user
committed
20331de
fs: add Copy same-backend decision tests with spy FS types
exe.dev user
committed
2d07789
fs/s3: integration test for CopySource with special keys (spaces, unicode, nested slashes)
exe.dev user
committed
34c973d
fs/local: pin Remove/RemoveAll guards, ctx-cancel and nil-delete contract
exe.dev user
committed
2024a8d
fs/s3: add regression tests for large copy path
exe.dev user
committed
affd078
fs/s3: guard s3File with mutex; log Seek body-close errors
exe.dev user
committed
4310a03
fs/local: atomic Write via temp file and rename
exe.dev user
committed
e7d6ca3
fs/s3: unit tests for write() ContentLength sniffing
exe.dev user
committed
fec479e
fs: document atomic write guarantee on WriteFS and local Write
exe.dev user
committed
9417c97
fs/s3: pin dirEntries empty-prefix behavior (mock tests)
exe.dev user
committed
0a5b401
fs/local: add atomic Write tests (large payload, cancel cleanup, reader concurrency, temp lifecycle)
exe.dev user
committed
70238b9
fs: document WriteFS.Remove missing-file contract (ErrNotExist on all backends)
exe.dev user
committed
e849a77
fs/s3: remove() HEAD-checks existence before DeleteObject (missing key -> ErrNotExist)
exe.dev user
committed
172b1a9
fs: regression tests for WriteFS.Remove missing-key and "." contracts
exe.dev user
committed
fbd4102
fs/s3: empty bucket reads dir="." as an empty directory, not ErrNotExist
exe.dev user
committed
00da8bd
fs/s3: write() ContentLength sniffing reports remaining, not total size
exe.dev user
committed
9c07fce
fs/s3: unit tests pin conditional-put error mapping and exhausted-reader ContentLength
exe.dev user
committed
fc6a424
fs/s3: percent-encode copy-source paths, skip dir placeholders, map missing keys to ErrNotExist
exe.dev user
committed
4339dc3
Merge fs backend fixes (kanban batch 1)
exe.dev user
committed
e21977f
fs/s3: surface per-key failures in removeAll batch DeleteObjects
exe.dev user
committed
655d5bc
fs: fix fileWalk nil-deref on error-yielding DirEntries
exe.dev user
committed
4bd9bf8
fs/s3: regression test for partial-failure batch DeleteObjects in RemoveAll
exe.dev user
committed
526de26
fs/s3: run deferred MPU abort/complete on non-canceled context
exe.dev user
committed
fcfe2e2
fs/s3: guard copy() against nil ContentLength on HEAD
exe.dev user
committed
9549063
fs/s3: guard openFile against nil ContentLength on HEAD
exe.dev user
committed
6095847
fs: yield ReadDir error before partial entries in wrapfs DirEntries
exe.dev user
committed
e7e36c4
fs/local: cut tempFileName at UTF-8 rune boundary
exe.dev user
committed
0ac1238
fs/s3: prefer seeker remaining length for fs.File ContentLength
exe.dev user
committed
8d93f68
fs/s3: prefer seeker remaining length for fs.File ContentLength
exe.dev user
committed
f823121
fs/s3: wrap fs.ErrNotExist around underlying error instead of replacing it
exe.dev user
committed
c00f30a
fs: add contract test for error-yielding DirEntries walk
exe.dev user
committed
3ac60f1
fs/s3: guard walkFiles FileRef construction against nil object fields
exe.dev user
committed
a2a4f2c
fs/s3: copy MultiCopier PartSize/Concurrency into locals in Copy
exe.dev user
committed
767142f
fs/s3: seeker sniff restores position, errors on failed restore
exe.dev user
committed
5cb85e4
fs/s3: regression tests for nil ContentLength on HEAD
exe.dev user
committed
c326b87
fs: RemoveAll('.') joins per-entry errors, threads prefixes, prefers backend batch
exe.dev user
committed
656a194
fs/local: preserve symlink mode via Lstat in Write atomic rename
exe.dev user
committed
b85ed2d
fs/s3: integration regression tests for ContentLength sniffing
exe.dev user
committed
ee8b0df
fs/s3: regression test for concurrent MultiCopier.Copy reuse
exe.dev user
committed
997ea71
fs/local: document and pin RemoveAll symlink safety
exe.dev user
committed
deaa4b0
fs/local: add Windows rename-overwrite helper using MoveFileEx
exe.dev user
committed
3a1ad19
fs/s3: release mu during s3File.Read network I/O; Seek no longer stalls
exe.dev user
committed
49b0740
fs: add WalkFiles contract tests for early termination and error propagation
exe.dev user
committed
162095c
fs: document RemoveAll best-effort semantics in WriteFS contract
exe.dev user
committed
f6f5305
fs/s3: ContentLength sniff reports remaining bytes for *bytes.Reader
exe.dev user
committed
47d5619
fs/local: RemoveAll never follows intermediate symlinks out of the root
exe.dev user
committed
e92876f
fs: tests for RemoveAll('.') partial failure, batch path, and prefix threading
exe.dev user
committed
4a21457
fs/local: wire Windows rename helper into Write, correct atomicity docs, add rename tests
exe.dev user
committed
2041a91
fs/s3: stamp FS inside walkFiles, drop WalkFiles re-yield wrapper
exe.dev user
committed
8b3603d
fs/s3: regression tests for concurrent Read/Seek and h2 connection reuse
exe.dev user
committed
6fedf8b
fs/s3: document s3File as not concurrency-safe, drop locking machinery

exe.dev user
and
claude
committed
ae834ba
fs: dispatch RemoveAll(".") through a RootRemover interface

exe.dev user
and
claude
committed
ba72f68
fs/local: don't stamp a symlink's 0777 onto the replacement file
exe.dev user
committed
fea16d5
fs/s3: don't panic in SameBackend on a non-comparable client
exe.dev user
committed
b32a6b0
fs: trim redundant copy/removeall machinery
exe.dev user
committed
3d1933e
fs: restate test comments as invariants, not change history
exe.dev user
committed
6a2d755
internal/testutil: cross-backend contracts for Write, RemoveAll and DirEntries
exe.dev user
committed
a1a6c01
fs/s3/internal/mock: record calls in the mock, drop three wrapper types
exe.dev user
committed
423077f
fs/s3: split the fs_test.go grab-bag, extract shared helpers
exe.dev user
committed
7caa03c