Bug: SubprocessSandbox leaks file descriptors on timeout - #255
Open
pradeep0153 wants to merge 1 commit into
Open
Bug: SubprocessSandbox leaks file descriptors on timeout#255pradeep0153 wants to merge 1 commit into
SubprocessSandbox leaks file descriptors on timeout#255pradeep0153 wants to merge 1 commit into
Conversation
|
@pradeep0153 is attempting to deploy a commit to the sreerevanth's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #238.
Description
This PR resolves a critical resource-management bug within the global Sandbox architecture that was actively crashing the host operating system during long debugging sessions. There was a resource leak in
SubprocessSandboxwhen a test suite hung and hit thetimeout_secondslimit.When
subprocess.run()timed out, Repopilot correctly killed the child process. However, the capturedstdoutandstderrpipes were mathematically not explicitly closed in the exception handler. If the agent ran against a repository with consistently hanging tests over many iterations (e.g.,--max-iter 20), the host OS eventually threw aToo many open files(OSError: [Errno 24]) exception, violently crashing the entire agent loop and corrupting the run state.Changes Made
SubprocessSandbox.run_testsmethod..close()calls on standard IO pipes during a timeout exception.subprocess.Popenwithin a strict context manager (with subprocess.Popen(...) as p:). This mathematically guarantees that regardless of how the process exits—whether gracefully, viaTimeoutExpired, or via manualSIGKILL—the underlying OS file descriptors forstdoutandstderrare instantly and safely closed.Impact