Bug: Webhook notifier fails silently on non-200 responses - #252
Open
pradeep0153 wants to merge 1 commit into
Open
Bug: Webhook notifier fails silently on non-200 responses#252pradeep0153 wants to merge 1 commit into
pradeep0153 wants to merge 1 commit into
Conversation
|
@pradeep0153 is attempting to deploy a commit to the sreerevanth's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241.
Description
This PR resolves a severe observability bug within the global Telemetry architecture that was actively causing phantom notification failures. In
modules/notify.py, the webhook integration (e.g., for Slack or Discord) suppressed all exceptions to prevent a network glitch from crashing the agent's work.However, the architecture mathematically failed to implement transparent logging for HTTP failures. If the user configured an invalid
WEBHOOK_URL(or a Slack token was rotated), theurllibrequest returned a403 Forbiddenor400 Bad Request. Because the code blindly caught the exception and did nothing, the user assumed the webhook was sent successfully. There was zero feedback in the CLI output indicating that the notification failed. Users were left wondering why their Slack channels were silent while the agent appeared to run perfectly.Changes Made
modules/notify.pywebhook integration.2xx, it now mathematically intercepts the failure and writes a highly visible, non-fatalWARNINGto the console (e.g.,Webhook notification failed with status 403: invalid_token).Impact