Bug: Docker container sweep aggressively removes unrelated containers - #250
Open
pradeep0153 wants to merge 1 commit into
Open
Conversation
|
@pradeep0153 is attempting to deploy a commit to the sreerevanth's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #243.
Description
This PR resolves a critical concurrency bug within the global Sandbox architecture that was actively crashing parallel agent workflows. The
DockerSandbox.sweep_orphaned_containers()method acts as a garbage collector for leaked test containers.However, the sweep logic was mathematically too aggressive. It listed all containers globally tagged with the
com.repopilot.sandbox=truelabel and forcefully removed them (docker rm -f). If a developer ran two instances of Repopilot concurrently on different repositories (e.g., frontend and backend), Instance A's sweep aggressively killed Instance B's actively running test container. This mathematical failure caused Instance B to instantly crash with a spurious "process killed" error, completely destroying multi-agent concurrency.Changes Made
modules/sandbox.py.com.repopilot.run_id=<uuid>. Thesweep_orphaned_containersmethod now accepts an optionalrun_idparameter, ensuring the garbage collector only targets and removes containers specifically spawned by the current active process.Impact