Fix broken inverter detection - #211
Open
dezzak wants to merge 6 commits into
Open
Conversation
…ectly detected. These are detected as multiple inverters - both X1LiteLV and X1HybridGen4 and X1LiteLV is errorneously returned first.
This stops it detecting multiple inverters when both have an integer type. I don't know if this will break the X1LiteLV type though
Contributor
Author
|
Not sure why black is failing - it runs locally, and is complaining about files that I haven't touched 🤷 |
|
Hello @squishykid, Home Assistant has upgraded the dependency on your package to 3.2.4 recently. This PR with a small change (or the alternative #213) fixes an important issue in your package since version 3.2.4 (present since September last year) and is now breaking thousands of Home Assistant inverters. Can you therefore please merge either this PR or PR #213 and release it as a tag? It's not a big fix or much work. This would be immensely helpful, thanks so much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3.2.4 introduced a breaking change where some inverter types were incorrectly detected as X1_Lite_LV.
This change adds an extra check to the X1_Lite_LV type detection so that it only matches when the type is 103. I'm not sure if this will break the X1_Lite_LV inverters as there's only one example payload, but it certainly fixes my own inverter's detection.