Repository navigation
build: support Java 17 and later - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlcj, its runtime, and the code it generates now build and run on Java 17 or later instead of requiring Java 21, so projects still on the Java 17 LTS can adopt it. The generated code, the runtime API, and every diagnostic are unchanged.
Changes
--release 17; runtime and CLI class files now target Java 17.JdbcQueryExecutorparameter binding become type patterns with record accessors;List.getFirst()/getLast()become index access in main and test sources;SourceVersion.RELEASE_17, which answers identically for the identifiers sqlcj checks;instanceofin the SQL parameter compiler becomes a null check with the same error message.Scope and non-goals