Repository navigation
test: cover enum and array schemas and migrated-schema execution - #48
Merged
omer-cengel merged 2 commits intoSep 28, 2026
Merged
Conversation
omer-cengel
deleted the
chore/migration-directory-and-enum-array-schema-tests
branch
September 28, 2026 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds acceptance tests showing that PostgreSQL schemas shaped like published sqlc examples load as documented, and that a migration directory runs end to end: PostgreSQL applies the files, and code generated from the same directory executes against the migrated tables.
Changes
varchar[]column, indexes, and a dollar-quoted function followed by another statement loads, with the enum and array columns recorded as unsupported types.COMMENT ON TYPEfails on that statement with a located syntax diagnostic (Encountered unexpected token: "TYPE" at line 14, column 12).COMMENT ON TABLE/COLUMNstatements and the enum type, rename a table, drop one column and add another, and record the enum, enum-array, andtext[]columns as unsupported.Scope and non-goals
COMMENT ON TYPEstays a syntax error; sqlcj does not pre-process SQL to skip it.