Repository navigation
feat(schema): accept PostgreSQL spellings of supported column types - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Schemas written for PostgreSQL often use the type names PostgreSQL itself documents, such as
TIMESTAMPTZ,INT8,SERIAL8, orCHARACTER VARYING(20). sqlcj previously rejected these withUnsupported SQL column type. They now map to the same Java types as the spellings sqlcj already accepted, so an existing PostgreSQL schema no longer has to be rewritten for code generation.Changes
INT4andSERIAL4map toInteger;INT8andSERIAL8map toLong;INT2,SMALLSERIAL, andSERIAL2map toShort.CHARACTER VARYING,CHAR, andCHARACTERmap toString. PostgreSQL blank-padsCHAR(n)values, soabstored inCHAR(3)reads back asab.TIMESTAMP WITHOUT TIME ZONEmaps tojava.time.LocalDateTimeandTIMESTAMPTZtojava.time.OffsetDateTime.SMALLSERIAL,SERIAL,BIGSERIAL,SERIAL2,SERIAL4,SERIAL8) is modeled as non-null. The integer aliases take their nullability fromNOT NULLonly.Scope and non-goals
CHAR VARYING,DEC,NCHAR,BPCHAR), quoted or schema-qualified type names, the distinct"char"type, and array types remain unsupported.