Repository navigation
ci: verify sample regeneration and document manifest cleanup - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release verification now proves that the external sample regenerates repeatably and cleanly: generation works with an explicit configuration path from another working directory, identical input reproduces identical sources and manifest, and a renamed or removed query group leaves no stale repository behind. The quickstart's regeneration guidance now describes the output manifest and its cleanup.
Changes
scripts/verify-release.shgenerates the copied sample withgenerate --config ../sample/sqlcj.yamlfrom an empty sibling directory, checks that the repository andsqlcj-manifest.txtare written and that the working directory stays empty, then generates again and requires a byte-identical output tree.AuthorandLibraryand then onlyWriter; the script requires the old repositories to be gone,WriterRepository.javato be the only generated source, and the manifest to list it alone.sqlentry, explains that regeneration deletes it, and keepsmvn cleanbecause compiled classes are never deleted.Scope and non-goals
generate --checkmode are not added;mvn cleanremains part of the documented sequence.