Repository navigation
fix: report output write failures as one sqlcj diagnostic - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
sqlcj generatecould not create an output directory or write a generated file, the failure escaped as an unhandled exception with a stack trace. It now ends the run with a singlesqlcj:diagnostic naming the resolved path that could not be written, and exit status1, matching how configuration and source failures are already reported.Changes
Cannot create output directory: <path>when a generated file's parent directory cannot be created, andCannot write generated file: <path>when the file itself cannot be written; both use the resolved path and keep the underlying filesystem exception as the cause.CompilationException, so the existinggenerateerror handling prints one line and exits with status1without a stack trace.Scope and non-goals
--configpath resolution are unchanged.