Repository navigation
feat(analysis): accept LEFT JOIN with nullable joined columns - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reads can now use
LEFT JOIN(and itsLEFT OUTER JOINspelling) with the same single qualifiedONequality already required for inner joins. Because an unmatched row supplies no value for the joined table, every column projected from a left-joined source is analyzed as nullable, so the generated result reportsnullcomponents for unmatched rows instead of claiming a non-null value.Changes
LEFT JOINandLEFT OUTER JOINalongsideJOIN/INNER JOIN, chained with inner joins in any order, keeping the existingONequality rules and diagnostics.qualifier.*, and*projections, even when the schema declares itNOT NULL; the base and inner-joined sources keep their schema nullability.Only unmodified INNER JOIN and LEFT JOIN clauses are supported.ONshapes that stay rejected, plus a PostgreSQL integration test that compiles and runs a left join returningnullcomponents for an unmatched row.Scope and non-goals
RIGHT,FULL, bareOUTER,NATURAL,SEMI,APPLY,USING (...), comma-separated sources, and non-table join sources remain rejected.