Conversation
… subprocesses. It might also improve the chance for working on windows. The remaining failing examples are marked as XFAIL. Also some debug prints are removed
antocuni
reviewed
Jul 21, 2026
Comment on lines
+128
to
+129
| if spy_file.stem in ['collections','annotated','unroll_nested_loops','convert']: | ||
| pytest.xfail() |
Member
There was a problem hiding this comment.
I'm not sure about this approach.
The biggest issue is that it doesn't solve the problem that you encountered during the sprint, i.e. that you opened an example, tried to compile and see it was broken.
I think that a better way is the following:
- add a special "marker" at the beginning of the docstring of examples which are known not to compile
- detected the marker here (could be something as simple as
if MARKER in spy_file.read()).
What to use as a marker is open to discussion, but I propose something like this in the first line of the docstring:
"""
SPY BUILD: xfail
Things to notice:
- Tuples, dicts, and lists work as in Python.
[...]
"""
def main() -> None:
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a way to test if the examples work when compiled. Due to a problem of getting the correct return code with the "spy bull -x", the building process is separate from the test of the executable.
There are four examples that are not compilable at this point in time, and these examples are marked as XFAIL.
AI was not used in this pull request